Drop 7.10 #509
Merged
Drop 7.10 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js v7.10.x is no longer actively maintained. See: https://github.com/nodejs/LTS
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I'll merge this and work on the docker hub PR |
|
Not sure if this needs a docker hub PR? Unless they periodically rebuild images to get updates from base images this won't change anything until the next change in other images. |
|
It's not strictly necessary in terms of the hub but it's better to have this handled in a discreet PR that can be referenced in the future - or in case the change needs to be reversed for whatever reason. I tend to approach the PRs to the docker hub like I do for PR's in general - each PR should be dedicated to one specific change. |
|
Fair enough 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js v7.10.x is no longer actively maintained.
See: https://github.com/nodejs/LTS