Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 'Architectures' information #472

Merged
merged 1 commit into from
Jul 23, 2017

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Jul 21, 2017

Enhance the generate-stackbrew-library.sh to generate Architectures
information.

Signed-off-by: Yihong Wang [email protected]

@yhwang
Copy link
Member Author

yhwang commented Jul 21, 2017

The output of generate-stackbrew-library.sh would be:

# this file is generated via https://github.com/nodejs/docker-node/blob/1afed76eb4695440267fc5b7404ea0cf90023bd0/generate-stackbrew-library.sh

Maintainers: The Node.js Docker Team <https://github.com/nodejs/docker-node> (@nodejs)
GitRepo: https://github.com/nodejs/docker-node.git

Tags: 8.2.1, 8.2, 8, latest
Architectures: amd64, ppc64le
GitCommit: f547c4c7281027d5d90f4665815140126e1f70d5
Directory: 8.2

Tags: 8.2.1-alpine, 8.2-alpine, 8-alpine, alpine
Architectures: amd64
GitCommit: f547c4c7281027d5d90f4665815140126e1f70d5
Directory: 8.2/alpine

Tags: 8.2.1-onbuild, 8.2-onbuild, 8-onbuild, onbuild
Architectures: amd64, ppc64le
GitCommit: f547c4c7281027d5d90f4665815140126e1f70d5
Directory: 8.2/onbuild

Tags: 8.2.1-slim, 8.2-slim, 8-slim, slim
Architectures: amd64, ppc64le
GitCommit: f547c4c7281027d5d90f4665815140126e1f70d5
Directory: 8.2/slim

Tags: 8.2.1-wheezy, 8.2-wheezy, 8-wheezy, wheezy
Architectures: amd64
GitCommit: f547c4c7281027d5d90f4665815140126e1f70d5
Directory: 8.2/wheezy

Tags: 7.10.1, 7.10, 7
Architectures: amd64, ppc64le
GitCommit: 0aadad9c44ff26afc81469d77df9b948be47c312
Directory: 7.10

Tags: 7.10.1-alpine, 7.10-alpine, 7-alpine
Architectures: amd64
GitCommit: 0aadad9c44ff26afc81469d77df9b948be47c312
Directory: 7.10/alpine

Tags: 7.10.1-onbuild, 7.10-onbuild, 7-onbuild
Architectures: amd64, ppc64le
GitCommit: 0fcdf0b2660e73ab1054f932f4beac5b3946fb21
Directory: 7.10/onbuild

Tags: 7.10.1-slim, 7.10-slim, 7-slim
Architectures: amd64, ppc64le
GitCommit: 0aadad9c44ff26afc81469d77df9b948be47c312
Directory: 7.10/slim

Tags: 7.10.1-wheezy, 7.10-wheezy, 7-wheezy
Architectures: amd64
GitCommit: 0aadad9c44ff26afc81469d77df9b948be47c312
Directory: 7.10/wheezy

Tags: 6.11.1, 6.11, 6, boron
Architectures: amd64, ppc64le
GitCommit: bb200caf20280e436dedc56a5f194fd21e684758
Directory: 6.11

Tags: 6.11.1-alpine, 6.11-alpine, 6-alpine, boron-alpine
Architectures: amd64
GitCommit: bb200caf20280e436dedc56a5f194fd21e684758
Directory: 6.11/alpine

Tags: 6.11.1-onbuild, 6.11-onbuild, 6-onbuild, boron-onbuild
Architectures: amd64, ppc64le
GitCommit: bb200caf20280e436dedc56a5f194fd21e684758
Directory: 6.11/onbuild

Tags: 6.11.1-slim, 6.11-slim, 6-slim, boron-slim
Architectures: amd64, ppc64le
GitCommit: bb200caf20280e436dedc56a5f194fd21e684758
Directory: 6.11/slim

Tags: 6.11.1-wheezy, 6.11-wheezy, 6-wheezy, boron-wheezy
Architectures: amd64
GitCommit: bb200caf20280e436dedc56a5f194fd21e684758
Directory: 6.11/wheezy

Tags: 4.8.4, 4.8, 4, argon
Architectures: amd64, ppc64le
GitCommit: 3ffba881ad5a78d33b8edf888d5406222b60686e
Directory: 4.8

Tags: 4.8.4-alpine, 4.8-alpine, 4-alpine, argon-alpine
Architectures: amd64
GitCommit: 3ffba881ad5a78d33b8edf888d5406222b60686e
Directory: 4.8/alpine

Tags: 4.8.4-onbuild, 4.8-onbuild, 4-onbuild, argon-onbuild
Architectures: amd64, ppc64le
GitCommit: 3ffba881ad5a78d33b8edf888d5406222b60686e
Directory: 4.8/onbuild

Tags: 4.8.4-slim, 4.8-slim, 4-slim, argon-slim
Architectures: amd64, ppc64le
GitCommit: 3ffba881ad5a78d33b8edf888d5406222b60686e
Directory: 4.8/slim

Tags: 4.8.4-wheezy, 4.8-wheezy, 4-wheezy, argon-wheezy
Architectures: amd64
GitCommit: 3ffba881ad5a78d33b8edf888d5406222b60686e
Directory: 4.8/wheezy

@yhwang
Copy link
Member Author

yhwang commented Jul 21, 2017

@tianon Can you help to verify the output? and also help to review my change. Thanks.

@tianon
Copy link
Contributor

tianon commented Jul 21, 2017

Output seems sane -- I think the wheezy variants could probably add ppc64le as well, but IIRC @chorrell is gunning for their removal anyhow (#466). 😈

@tianon
Copy link
Contributor

tianon commented Jul 21, 2017

(Also worth noting that Alpine can't officially be made multiarch until gliderlabs/docker-alpine#304 is resolved. 👍)

@yhwang
Copy link
Member Author

yhwang commented Jul 21, 2017

There is no wheezy here: https://hub.docker.com/r/ppc64le/buildpack-deps/ . So in my previous PR, I didn't add wheezy variant for ppc64le. :-)

Thanks!

@tianon
Copy link
Contributor

tianon commented Jul 21, 2017 via email

@yhwang
Copy link
Member Author

yhwang commented Jul 21, 2017

For alpine, only amd64 supports alpine now. ppc64le could not support alpine until a fix get into v8. Based on your suggestion. I won't add any architecture for the alpine except amd64 if I need to add more architecture support in the future.

SimenB

This comment was marked as off-topic.

Starefossen

This comment was marked as off-topic.

Enhance the `generate-stackbrew-library.sh` to generate `Architectures`
information.

Signed-off-by: Yihong Wang <[email protected]>
@yhwang yhwang force-pushed the add-architecture-to-stackbrew branch from 1afed76 to bb2de80 Compare July 23, 2017 04:39
@yhwang
Copy link
Member Author

yhwang commented Jul 23, 2017

Thanks @SimenB, @tianon and @Starefossen force push again now.

@SimenB SimenB merged commit bc4e7ee into nodejs:master Jul 23, 2017
@yhwang yhwang deleted the add-architecture-to-stackbrew branch July 23, 2017 14:59
@SimenB
Copy link
Member

SimenB commented Jul 26, 2017

See docker-library/official-images#3238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants