Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types in package exports #10

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

BerkliumBirb
Copy link
Contributor

@wolfram77
Copy link
Member

Are you an android from Cyberlife?

@BerkliumBirb
Copy link
Contributor Author

Sorry? I didn't play Detroit, so I don't get the reference...

Do you need anything from my side to publish this update? I really need this to remove @ts-ignore from my code. Would really appreciate.

@wolfram77
Copy link
Member

Hey. Can you give me a screenshot of the issue you are facing? I am not clear why you are getting an error related to ts-ignore, and how this resolves it.

Also, do I need to pick better questions for my turing test?

@BerkliumBirb
Copy link
Contributor Author

I can't provide screenshot, but here's what tsc (5.3.3) spits out:

src/services/Recalculate.ts:2:22 - error TS7016: Could not find a declaration file for module 'extra-bigint'. '/home/me/Project/node_modules/extra-bigint/index.mjs' implicitly has an 'any' type.
  There are types at '/home/me/Project/node_modules/extra-bigint/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'extra-bigint' library may need to update its package.json or typings.

2 import { sqrt } from "extra-bigint";

I don't know how can you conduct a Turing's test in GH Issues. But as far as I know LLMs can't really do two separate logical threads inside one actual conversation simultaneously.

@wolfram77
Copy link
Member

Thanks. If your second point is true, it likely wont stay true for much longer - it is getting trained on your conversation.

@wolfram77 wolfram77 merged commit 265a444 into nodef:master Mar 20, 2024
9 checks passed
@BerkliumBirb
Copy link
Contributor Author

Would also be great if you release this change to npm.

@wolfram77
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants