Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type for resolveTopicArn in SQS needs to be fixed #143

Closed
maganuk opened this issue Oct 9, 2021 · 2 comments · Fixed by #146
Closed

Type for resolveTopicArn in SQS needs to be fixed #143

maganuk opened this issue Oct 9, 2021 · 2 comments · Fixed by #146

Comments

@maganuk
Copy link

maganuk commented Oct 9, 2021

The current type for the options in SQS is incorrect after the update. It expects the function to take in only the topic name. It should be (awsAccountId: string, awsRegion: string, topicName: string) and not just (topicName: string)
@maganuk maganuk changed the title Types for resolveTopicArn in SQS needs to be fixed Type for resolveTopicArn in SQS needs to be fixed Oct 9, 2021
@adenhertog adenhertog mentioned this issue Oct 10, 2021
Merged
adenhertog added a commit that referenced this issue Oct 10, 2021
@adenhertog
#143 - Fix sqs configuration (#146)
62d00d7 
* fix configuration

* fix codedoc

* lint fix
@adenhertog
Copy link
Contributor

thanks @maganuk really appreciate the report 🙏

@maganuk
Copy link
Author

maganuk commented Oct 10, 2021

@adenhertog thanks for building this wonderful library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#143 - Fix sqs configuration node-ts/bus
2 participants
@adenhertog @maganuk