#126 - Use promise.allSettled() during message dispatch #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126
This uses
promise.allSettled()
instead ofpromise.all()
when dispatching the same message to multiple handlers on the same instance. This is done as there is no coupling between handlers and failure in one shouldn't affect processing in another.Note that this still throws all errors from the dispatch that are now inside the
HandlerDispatchRejected
error in thereasons
attribute.The message will still be retried, so it's still important as always to ensure message handling is idempotent.