Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Promise.allSettled when dispatching to handlers #126

Closed
adenhertog opened this issue Aug 3, 2021 · 0 comments · Fixed by #168
Closed

Use Promise.allSettled when dispatching to handlers #126

adenhertog opened this issue Aug 3, 2021 · 0 comments · Fixed by #168
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@adenhertog
Copy link
Contributor

When multiple handlers receive the same message, a rejection in one shouldn't stop processing in others. This isn't the case due to the use of Promise.all in ServiceBus.dispatchMessageToHandlers.

Consider using Promise.settledAll and only failing the message after all work has completed and there's at least one rejection.
@adenhertog adenhertog added good first issue Good for newcomers bug Something isn't working labels Aug 3, 2021
@adenhertog adenhertog mentioned this issue Nov 20, 2021
Merged
adenhertog added a commit that referenced this issue Nov 21, 2021
@adenhertog
#126 - Use promise.allSettled() during message dispatch (#168)
a5fb992 
* use promise.allSettled() during message dispatch

* enhance docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#126 - Use promise.allSettled() during message dispatch node-ts/bus
1 participant
@adenhertog