Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: able to set limits and setpoint to zero #92

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

hoegge
Copy link
Contributor

@hoegge hoegge commented Sep 25, 2022

With the current implementation you cannot set any of the limits or the setpoint to zero, since 0 is falsy.

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)

Proposed changes

You cannot set, e.g., low limit to 0 since 0 is falsy. Checking limits and setpoint for zero now and sets to 0 instead of default values in that case, which will confuse people.

Checklist

With the current implementation you cannot set any of the limits or the setpoint to zero, since 0 is falsy.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 25, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hoegge / name: Morten H Pedersen (eeb8a96)

@dceejay
Copy link
Member

dceejay commented Sep 25, 2022

Good catch . Thanks !

@dceejay dceejay merged commit e91f990 into node-red:master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants