UI webcam save defaults #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2021 09:48
and set camera via msg.camera
This reverts commit a65f3e7.
knolleary
reviewed
Sep 24, 2021
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR lets the user set the default camera to use (via the select dropdown) and that is then stored in the browser localStorage for next time it is used.
It also adds and allows a
msg.cameracontrol message that can be set to the index in the list of available cameras (usually 0,1,2,3 etc) - if valid the stream will switch to that camera. If the camera is currently disabled it does NOT re-enable the camera.Checklist
gruntto verify the unit tests pass