Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI table single quote issue (#66) #68

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

wipfl
Copy link
Contributor

@wipfl wipfl commented Jun 3, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Issue #66 describes that a single-quote character in the description or the table name breaks the table so it is no longer rendered.

The JSON.stringify() call in function HTML has been changed so that

  • all single-quote characters (') are replaced by & apos ;
  • the info property is not copied to the stringified JSON.

A sample flow has been added to the example folder that tests the behaviour of the table with single and double quotes in table name, column name and description.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@dceejay dceejay merged commit 7def1a5 into node-red:master Jul 8, 2021
@dceejay
Copy link
Member

dceejay commented Jul 8, 2021

Many thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants