Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaling support of embedded page to ui-iframe node #58

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This PR add scaling feature of embedded web page to ui-iframe node.
An example of the new feature can be found in Import/Examples/node-red-node-ui-iframe/04 - Scale embedded web page.json.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Copy link
Member

@dceejay dceejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few little things for feedback

node-red-node-ui-iframe/package.json Outdated Show resolved Hide resolved
node-red-node-ui-iframe/ui_iframe.html Show resolved Hide resolved
node-red-node-ui-iframe/ui_iframe.js Show resolved Hide resolved
node-red-node-ui-iframe/ui_iframe.html Outdated Show resolved Hide resolved
@dceejay dceejay merged commit 453c17f into node-red:master Mar 22, 2021
@dceejay
Copy link
Member

dceejay commented Mar 22, 2021

Published to npm - many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants