Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr issue6 #11

Merged
merged 8 commits into from
May 18, 2020
Merged

Pr issue6 #11

merged 8 commits into from
May 18, 2020

Conversation

biancode
Copy link
Contributor

@biancode biancode commented May 1, 2020

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

#6 fix

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 97.917% when pulling b850d93 on BiancoRoyal:PRIssue6 into 93554fd on node-red:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 97.917% when pulling b850d93 on BiancoRoyal:PRIssue6 into 93554fd on node-red:master.

@biancode
Copy link
Contributor Author

biancode commented May 1, 2020

I hope the adding LTS to travis and new docs are OK for you.

@dceejay
Copy link
Member

dceejay commented May 1, 2020

much cleaner - thanks !

@biancode
Copy link
Contributor Author

biancode commented May 1, 2020

The README and node-red-amdin.js changes are there to give the user a consistent documentiation of the commands.

@biancode
Copy link
Contributor Author

biancode commented May 10, 2020

When could we get this released, please? Is there a way to become part as a maintainer here?

@knolleary
Copy link
Member

My only hesitation (which has only just occurred to me in this context) is we know the npm search index is generally out of date and we've had to stop using it to find nodes. This means you'd get different results to what the palette manager shows or the flow library itself.

We should update the tool to query the flow library, rather then npm. Currently on a snack break mid-family bike ride. I'll add some comments tonight on what would be needed.

@knolleary
Copy link
Member

I've got the search working in my local dev environment. It's a simple enough fix to switch over to the flow library api.

I will merge this PR to pick up the other doc changes you've made, but then I'll make the updates for the flow library api. Once that's all done, I'll publish a version of the module.

@knolleary knolleary merged commit ece2c05 into node-red:master May 18, 2020
@knolleary
Copy link
Member

0.1.8 now published to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants