refactor: update ESLint to 6.0.0 #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update deps within ranges in package.json. `rm -rf node_modules/ && rm package-lock.json && npm i`
paulmelnikow
approved these changes
Jun 22, 2019
lib/back.js
Outdated
| @@ -266,7 +264,7 @@ const Modes = { | |||
| } | |||
|
|
|||
| Back.setMode = function(mode) { | |||
| if (!Modes.hasOwnProperty(mode)) { | |||
| if (!Object.prototype.hasOwnProperty.call(Modes, mode)) { | |||
There was a problem hiding this comment.
Could we replace these hasOwnProperty calls with mode in Modes?
| this[propName] = overrider[propName] | ||
| } | ||
| } | ||
| Object.assign(this, overrider) |
|
🎉 This PR is included in version 11.0.0-beta.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
* chore(package): update eslint to version 6.0.0 * chore: lockfile maintenance * refactor: changes required for eslint v6 updated `recommend`ed rules * chore: remove no longer needed lint rule overrides * refactor: replace deprecated `assert.equal` -> `assert.strictEqual`
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
* chore(package): update eslint to version 6.0.0 * chore: lockfile maintenance * refactor: changes required for eslint v6 updated `recommend`ed rules * chore: remove no longer needed lint rule overrides * refactor: replace deprecated `assert.equal` -> `assert.strictEqual`
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
* chore(package): update eslint to version 6.0.0 * chore: lockfile maintenance * refactor: changes required for eslint v6 updated `recommend`ed rules * chore: remove no longer needed lint rule overrides * refactor: replace deprecated `assert.equal` -> `assert.strictEqual`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1592
ESLint offers a migration guide for their newest major release. There were two issues that kept nock from simply upgrading.
eslint-plugin-importlisted in thepackage-lock.jsonwas not compatible. The newest version of the plugin works and is within the range already defined inpackage.jsonso I simply performed lockfile maintenance (regenerating the lockfile from scratch).eslint:recommendedwas changed. The only new rule that really affected nock wasno-prototype-builtins.I also noticed we still had some instances of the deprecated
assert.equalin tests so I updated those to use the preferredassert.strictEqual.