Status code is ignored when response payload is empty

[StarpTech]

This will return the statusCode 200 but I expect 401. This can be fixed when I pass an empty response body like [401, '']. It this the desired bahviour?

    const verifyPublishedContentMock = Nock(callbackUrl)
      .post('/')
      .query(true)
      .reply(function(uri, requestBody) {
        return [401]
      })

[gr2m]

Could you please create a runkit notebook such as https://runkit.com/gr2m/node-nock-nock-768 to reproduce the problem?

[StarpTech]

@gr2m https://repl.it/@StarpTech/TestCase-1170 if you add a string to the array [401, ''] it will return 401 correctly.

[RichardLitt]

That looks like the desired behaviour to me. It may just be that you need to send a body, or it will default to 200. Is this an inconvenience?

This is set in lib/interceptor.js:

Interceptor.prototype.reply = function reply(statusCode, body, rawHeaders) {
    if (arguments.length <= 2 && _.isFunction(statusCode)) {
        body = statusCode;
        statusCode = 200;
    }
    ...

[StarpTech]

That looks like the desired behaviour to me. It may just be that you need to send a body, or it will default to 200. Is this an inconvenience?

Of course! When I send 401 I expect 401.

[RichardLitt]

Ok. Someone needs to take a look at the interceptor logic, then. I am at a loss as to how to do this easily.

For now, pass in an empty body in a string.

[StarpTech]

@RichardLitt I provide a fix #1203

[nockbot]

🎉 This issue has been resolved in version 10.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!