refactor: Remove unnecessary conditional, add test for undefined data

See #1404.

lib/recorder.js

@@ -380,18 +380,15 @@ function record(rec_options) {
 
  const oldWrite = req.write
  req.write = function(data, encoding) {
- // TODO-coverage: Is this for parity with native node `req.write()`? If
- // so, reference the native impelementation or its docs. If not, fail
- // loudly with an error.
  if (typeof data !== 'undefined') {
- if (data) {
- debug(thisRecordingId, 'new', proto, 'body chunk')
- if (!Buffer.isBuffer(data)) {
- data = Buffer.from(data, encoding)
- }
- bodyChunks.push(data)
+ debug(thisRecordingId, 'new', proto, 'body chunk')
+ if (!Buffer.isBuffer(data)) {
+ data = Buffer.from(data, encoding)
  }
+ bodyChunks.push(data)
  oldWrite.apply(req, arguments)
+ } else {
+ throw new Error('Data was undefined.')
  }
  }
 

tests/test_recorder.js

@@ -265,6 +265,24 @@ test('checks if callback is specified', t => {
  })
 })
 
+test('checks that data is specified', t => {
+ nock.restore()
+ nock.recorder.clear()
+ nock.recorder.rec(true)
+
+ const req = http.request({
+ method: 'POST',
+ host: 'localhost',
+ path: '/',
+ port: '80',
+ body: undefined,
+ })
+
+ t.throws(() => req.write(), { message: 'Data was undefined.' })
+ req.abort()
+ t.end()
+})
+
 test('when request body is json, it goes unstringified', t => {
  const server = http.createServer((request, response) => response.end())
  t.once('end', () => server.close())