Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept url with anchors #10

Merged
merged 2 commits into from
Dec 27, 2019
Merged

fix: accept url with anchors #10

merged 2 commits into from
Dec 27, 2019

Conversation

noandrea
Copy link
Owner

rel #9

to validate urls, instead of ParseRequestURI
improve robustness while dealing with database keys
@noandrea noandrea added this to the 0.3.0 milestone Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #10 into develop will increase coverage by 0.31%.
The diff coverage is 72.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #10      +/-   ##
===========================================
+ Coverage    48.54%   48.85%   +0.31%     
===========================================
  Files            8        8              
  Lines         1168     1181      +13     
===========================================
+ Hits           567      577      +10     
- Misses         501      503       +2     
- Partials       100      101       +1
Impacted Files Coverage Δ
urlstore/model.go 62.93% <100%> (+2.02%) ⬆️
urlstore/distill.go 80.62% <50%> (+1.09%) ⬆️
urlstore/urlstore.go 82.06% <61.53%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665e8aa...10f5804. Read the comment docs.

@noandrea noandrea merged commit 1bf7354 into develop Dec 27, 2019
@noandrea noandrea deleted the fix/8_anchor branch December 27, 2019 23:45
@noandrea noandrea restored the fix/8_anchor branch May 17, 2020 20:29
@noandrea noandrea deleted the fix/8_anchor branch June 23, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant