Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation for Chinese #395

Merged
merged 11 commits into from
Dec 15, 2022

Conversation

groverlynn
Copy link
Contributor

No description provided.

@groverlynn
Copy link
Contributor Author

Sorry for opening another pull. I reorganized branches in my fork, which closed #385

@noah-nuebling
Copy link
Owner

Hey @groverlynn, no worries at all! Thanks again for all your effort!

I've now published Beta 4 and it contains all the UI additions and changes that I was still planning on.

So I think that that the UI is now finally "stable" and I won't change any more stuff that you've already translated unless it's absolutely necessary.

I'll be happy to merge your translations for Beta 5!

@groverlynn
Copy link
Contributor Author

This should now cover everything up to beta 4

@noah-nuebling
Copy link
Owner

noah-nuebling commented Nov 3, 2022

Hey @groverlynn!

I added one new new UI string with the key is-strange-helper-toast is-strange-helper-alert.title and is-strange-helper-alert.body in 3.0.0 Beta 5.
I also very slightly changed the English UI strings with the key is-disabled-toast and 9qp-gN-SZZ.title. Don't think it's necessary for you to update them.

Will probably merge your translations for Beta 6. I didn't merge for Beta 5 since many people had scrolling issues so I wanted to push the update sooner.

Thanks for your great work!

@noah-nuebling
Copy link
Owner

By the way how did you find out which UI Strings were added or changed before?

@groverlynn
Copy link
Contributor Author

groverlynn commented Nov 7, 2022

@noah-nuebling All updated now up to beta 5

By the way how did you find out which UI Strings were added or changed before?

I just go through the commits to see whether the localization strings files have been modified.

@groverlynn groverlynn force-pushed the version-3-zh branch 5 times, most recently from 0932362 to 1b9e790 Compare December 13, 2022 21:57
@groverlynn
Copy link
Contributor Author

Translation updated up to Beta 6

@noah-nuebling noah-nuebling merged commit aadba97 into noah-nuebling:version-3 Dec 15, 2022
@noah-nuebling
Copy link
Owner

Hey @groverlynn, at long last I've now finally merged your translations! They are looking great! Thanks again for your hard work.

@noah-nuebling
Copy link
Owner

If you shoot me an email at noah . n . public @ gmail . com I'll send you a bunch of free license keys

@groverlynn groverlynn deleted the version-3-zh branch January 13, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants