forked from apache/flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-2555] Properly pass security credentials in the Hadoop Input/O…
…utput format wrappers This is needed because the Hadoop IF/OF's are using Hadoop's FileSystem stack, which is using the security credentials passed in the JobConf / Job class in the getSplits() method. Note that access to secured Hadoop 1.x using Hadoop IF/OF's is not possible with this change. This limitation is due to missing methods in the old APIs. - Add some comments & change dependency scope to test
- Loading branch information
Showing
21 changed files
with
285 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
...va/src/main/java/org/apache/flink/api/java/hadoop/common/HadoopInputFormatCommonBase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http:https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.flink.api.java.hadoop.common; | ||
|
|
||
| import org.apache.flink.api.common.io.RichInputFormat; | ||
| import org.apache.flink.core.io.InputSplit; | ||
| import org.apache.hadoop.security.Credentials; | ||
| import org.apache.hadoop.security.UserGroupInformation; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.ObjectInputStream; | ||
| import java.io.ObjectOutputStream; | ||
| import java.lang.reflect.InvocationTargetException; | ||
| import java.lang.reflect.Method; | ||
|
|
||
| /** | ||
| * A common base for both "mapred" and "mapreduce" Hadoop input formats. | ||
| */ | ||
| public abstract class HadoopInputFormatCommonBase<T, SPITTYPE extends InputSplit> extends RichInputFormat<T, SPITTYPE> { | ||
| protected transient Credentials credentials; | ||
|
|
||
| protected HadoopInputFormatCommonBase(Credentials creds) { | ||
| this.credentials = creds; | ||
| } | ||
|
|
||
| protected void write(ObjectOutputStream out) throws IOException { | ||
| this.credentials.write(out); | ||
| } | ||
|
|
||
| public void read(ObjectInputStream in) throws IOException { | ||
| this.credentials = new Credentials(); | ||
| credentials.readFields(in); | ||
| } | ||
|
|
||
| /** | ||
| * This method only exists because there is no UserGroupInformation.getCredentials() method | ||
| * in Hadoop 1.x | ||
| * | ||
| * Note that this method returns "null" in Hadoop 1.x environments. | ||
| * | ||
| * @param ugi The user information | ||
| * @return new credentials object from the user information. MAY RETURN NULL! | ||
| */ | ||
| public static Credentials getCredentialsFromUGI(UserGroupInformation ugi) { | ||
| Method getCredentialsMethod = null; | ||
| for(Method m: ugi.getClass().getMethods()) { | ||
| if(m.getName().equals("getCredentials")) { | ||
| getCredentialsMethod = m; | ||
| break; | ||
| } | ||
| } | ||
| if(getCredentialsMethod == null) { | ||
| return null; | ||
| } else { | ||
| try { | ||
| return (Credentials) getCredentialsMethod.invoke(ugi); | ||
| } catch (InvocationTargetException | IllegalAccessException e) { | ||
| throw new RuntimeException("Unable to get credentials from UserGroupInformation. This is only supported by Hadoop 2.2.0+"); | ||
| } | ||
| } | ||
| } | ||
| } |
47 changes: 47 additions & 0 deletions
47
...a/src/main/java/org/apache/flink/api/java/hadoop/common/HadoopOutputFormatCommonBase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http:https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.flink.api.java.hadoop.common; | ||
|
|
||
| import org.apache.flink.api.common.io.RichOutputFormat; | ||
| import org.apache.hadoop.security.Credentials; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.ObjectInputStream; | ||
| import java.io.ObjectOutputStream; | ||
|
|
||
| /** | ||
| * A common base for both "mapred" and "mapreduce" Hadoop output formats. | ||
| * | ||
| * The base is taking care of handling (serializing) security credentials. | ||
| */ | ||
| public abstract class HadoopOutputFormatCommonBase<T> extends RichOutputFormat<T> { | ||
| protected transient Credentials credentials; | ||
|
|
||
| protected HadoopOutputFormatCommonBase(Credentials creds) { | ||
| this.credentials = creds; | ||
| } | ||
|
|
||
| protected void write(ObjectOutputStream out) throws IOException { | ||
| this.credentials.write(out); | ||
| } | ||
|
|
||
| public void read(ObjectInputStream in) throws IOException { | ||
| this.credentials = new Credentials(); | ||
| credentials.readFields(in); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.