-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rebase feature/optional
to develop
#4036
base: develop
Are you sure you want to change the base?
Conversation
Use JSON_HAS_CPP_17 only after it has been defined
…re/optional � Conflicts: � test/src/unit-conversions.cpp
…re/optional � Conflicts: � test/src/unit-conversions.cpp
Changed the base branch to I'm sorry if I'm making it a bit difficult here; I forked the repository and rebased |
I am also interested in having |
0ad3ad6
to
d27adfd
Compare
…SION is disabled.
See that clang-tidy is failing on some checks. Apparently this is on develop, too. I see that it is related to a supposed new check from clang-tidy v19: https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-designated-initializers.html. |
I'm on it. May take some more time. |
has this PR stalled again? |
I'm currently blocked by #4311. |
There has not been any activity in #4311 in a while. I wonder if this would be okay to merge? |
Rebasing
feature/optional
in attempt to revive this PR, referring to #2117.Sorry for long time between responses.
I may have been going forward with this the "wrong" way, so I apologize in advance.
Please let me know if this should be handled differently.
TODO
There is one test that is failing: Conversions from a default initialized
nlohmann::json
tostd::optional<T>
seems to fail. In the test case below, the last assertion fails with an exception. This is tested on Arch Linux with GCC 13.1.1.I was not able to figure out how to fix this so I need some assistance here.