Are these memory leak findings valid?

[farkasdvd]

Hello,
Our static analysis tool (Coverity) has detected a couple of memory leaks in the json_value union. Here is an example (there is a same finding for every ctor which calls create()):

Could someone who is familiar with the design confirm the validity of these findings? In the json_value union there is a destroy() method, which I assume is explicitly called before a json_value object goes out of scope. Is that the case?

[gregmarr]

Yes, the json_value object is contained in struct data and json_value::destroy() is called in data's destructor here:

https://github.com/nlohmann/json/blob/develop/include/nlohmann/json.hpp#L4223

    ~data() noexcept
    {
        m_value.destroy(m_type);
    }

The unique_ptr is used in the create function so that the memory is released if the T constructor throws.