Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: wait for hydration via react effect #319

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

katywings
Copy link
Collaborator

@katywings katywings commented Jun 25, 2024

This PR tries to reduce the flakiness of the tests as much as possible. But it isn't perfect: sometimes the page hydration just fails for unknown reasons, especially on Windows. The new isReady check tries to recover from hydration fails, by reloading the page, which seems to work pretty solidly. Longterm though we should think about rewriting a lot of the tests, especially those related to HMR & fixture.updateFile.

I ran the updated tests countless times with force-pushes and so far got zero fails with the latest version.

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 5f825cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 25, 2024

@katywings is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codesandbox bot commented Jun 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@katywings katywings force-pushed the fix-test-readyness branch 14 times, most recently from 9f672ca to 173663b Compare June 27, 2024 16:27
@katywings katywings changed the title [WIP] fix: wait for document load instead of networkidle in tests [WIP] fix: wait for hydration via react effect Jun 27, 2024
@katywings katywings force-pushed the fix-test-readyness branch 12 times, most recently from d84bdd3 to b7217ca Compare June 30, 2024 14:10
@katywings katywings force-pushed the fix-test-readyness branch 27 times, most recently from 129c3ea to 94de636 Compare July 1, 2024 21:08
@nksaraf nksaraf merged commit f0e0063 into nksaraf:main Jul 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants