Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vinxi MDX ignoring query params #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Jun 19, 2024

Currently, Vinxi MDX transforms MDX files whether they are imported with query params or not.
Since Vinxi MDX has enforce: "pre", it blocks features like ?raw query param from working correctly.
This PR fixes the issue by ensuring MDX files are only transformed when there are no query params.

Copy link

codesandbox bot commented Jun 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jun 19, 2024

@XiNiHa is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Jun 19, 2024

⚠️ No Changeset found

Latest commit: 0ff99ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
Copy link
Collaborator

Is it possible that MDX would still need query params.. stuff like pulling CSS out or file based route picking.. I'm actually not sure. But I wanted to put that out there.

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Jul 12, 2024

Just realized that Vite puts ?import when dynamically importing a module, therefore this will result in broken behaviors. I guess we need a better approach...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants