fix: use the proper url to walk through modules during dev style coll… #312
Conversation
…ection This also undoes the changes made by 3d79eb6 because the size of `staticImportedUrls` doesn't actually tell if the url is dynamically imported by its parent. We need a different way to detect dynamically imported modules.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 308d489 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@katywings is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Why do you see the logic I wrote before was flawed? From my understanding that is a valid way to detect whether modules are statically imported (since module nodes will have |
|
I just found that the issue was also excluding |
Is
We get flashes of unstyled content for any included css in dev.
Should
There should be no foucs.
Background
The happenings actually are much more complicated than the fix might suggest 🥴. We had a series of unfortunate events with the changes from the last release:
staticImportedUrlson the parent node, instead of the current node of the for-loopSince the logic for detecting dynamically imported modules was flawed from the beginning, I removed it which fixed 2a. Secondly I fixed the line that resulted in 2b.
Follow ups
Since this undoes the changes from #310 we need to discuss a better way to identify and exclude dynamically imported modules in the style collection - (..personally I am not a fan of excluding them and the resulting foucs, but if thats really the goal, then we should atleast do it properly 😅🙈)
Videos
Before fix
2024-06-19-08.47.25.144410757-c.mp4
After fix
2024-06-19-16.17.16.662965647-c.mp4