Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export lib/vite-dev for external use #300

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

GoodbyeNJN
Copy link
Contributor

Export the lib/vite-dev type to facilitate users to import the types defined in it.

For example, to provide convenience for defining user-configured types in the solid-start project.

https://github.com/solidjs/solid-start/blob/914647c9d122cfb3dd974d904012a8eb38898322/packages/start/config/index.d.ts#L2

Copy link

codesandbox bot commented May 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented May 25, 2024

⚠️ No Changeset found

Latest commit: bf7def7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 25, 2024

@GoodbyeNJN is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nksaraf nksaraf merged commit a09a057 into nksaraf:main Jun 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants