chore(vinxi): ensure installing vinxi only install one esbuild version #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align direct esbuild dependency version with transitive esbuild dependency from vite and nitropack.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Someone is attempting to deploy a commit to a Personal Account owned by @nksaraf on Vercel. @nksaraf first needs to authorize it. |
🦋 Changeset detectedLatest commit: 49fefb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align direct esbuild dependency version with transitive esbuild dependency from vite and nitropack.
When creating a solid-start app, both esbuild 0.18 and esbuild 0.20 are installed. This happens because the vite dependency in vinxi allows Vite 5.2.x which pulls in esbuild 0.20, but vinxi depends on esbuild 0.18.
Since vinxi uses esbuild directly just to process its own config, I thought it should be safe to update to esbuild 0.20, saving some download time and perplexity. I've also updated the Vite version range to make the result more consistent between installs with and without an existing package lock file.
Esbuild release notes: https://github.com/evanw/esbuild/releases