Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for icons in the https://materialdesignicons.com/ #6

Closed
wants to merge 1 commit into from

Conversation

Stexxen
Copy link

@Stexxen Stexxen commented Jun 13, 2015

Learned a bit of Gulp and thought this might be useful.

Adds Support for icons in the https://materialdesignicons.com/
Adds Command build-community which creates file mdi-icons.svg in iconsets

    Added Command build-community which creates file mdi-icons.svg in iconsets
    Removed Fill element on path tag, as this was making the icons default black
@nkoterba
Copy link
Owner

@Stexxen Thanks!

Yes, we were looking to add those icons as well though we've been updating our build environment to use other things.

I will take a look at this later this week/weekend and then pull it in unless I have any issues. Thanks for the contribution!

@nkoterba
Copy link
Owner

nkoterba commented Jul 2, 2015

@Stexxen

I found an issue with one of the community icons. It must've been added recently but it was using ellipse svg path instead of path so your delete test.g.path[0].fill was crashing gulp since path was undefined. Updated the gulpfile based on your help to pull community, build the iconset and remove a standard set of 'style' svg attributes:

'fill'
'fill-opacity'
'stroke-width'
'stroke-linejoin'

Thanks again for your efforts and your contribution. I'm going to close this since I didn't want to pull request your pull request to update your repo so then I could update my repo. Just updated mine directly.

@nkoterba nkoterba closed this Jul 2, 2015
@Stexxen
Copy link
Author

Stexxen commented Jul 7, 2015

@nkoterba No worries, thanks for the mention on the Readme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants