Support macOS asset naming scheme for versions prior to v0.102.0 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgeorgousis
changed the title
|
Thanks for the PR @alexgeorgousis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Overview
As described in #9, there was a change in the hugo naming scheme for macOS releases, which this plugin hasn't taken into account. The issue in question describes a problem with installing version 0.99.1, but the problem exists for all versions up-to-and-including 0.101.0.
To demonstrate the problem, version v0.102.0 includes the following macOS assets:
Whereas the version preceding it, v0.101.0, has the following macOS assets:
So, they seem to have replaced
universalwith architecture specific assets, but only for versions prior to v0.102.0.Change Summary
This PR updates the util function
download_release()to set thearchpart of the hugo asset URL touniversalfor macOS, only if the version is greater than or equal to v0.102.0.