Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not deprecate nix_direnv_watch_file yet (2.5.1) #421

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 27, 2023

we do this in 3.0.0

@Mic92 Mic92 requested a review from bbenne10 November 27, 2023 19:21
@Mic92 Mic92 changed the title do not deprecate nix_direnv_watch_file yet do not deprecate nix_direnv_watch_file yet (2.5.1) Nov 27, 2023
@Mic92 Mic92 mentioned this pull request Nov 27, 2023
Copy link
Contributor

@bbenne10 bbenne10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think we're due a 3.0 release shortly, but this will definitely hold us over.

@Mic92
Copy link
Member Author

Mic92 commented Nov 27, 2023

@mergify queue

Copy link
Contributor

mergify bot commented Nov 27, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1e3bd29

@mergify mergify bot merged commit 1e3bd29 into master Nov 27, 2023
11 checks passed
@Mic92 Mic92 deleted the revert-deprecation branch November 27, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants