Delay invalidating cache and gcroots until print-dev-env call succeeds #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently eagerly invalidate the gcroots and old profile rc, assuming that the devshell is in a usable state.
If this assumption does not hold,
we can invalidate a working state for a broken one.
Here we just delay calling
_nix_clean_old_gcroots
until we know that we're in a usable state.
In the case that the flake is in an unusable state, this simply reuses the latest working state.
This should address #412.