-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rio: add module #4118
rio: add module #4118
Conversation
46a25df
to
a48b24a
Compare
}) | ||
|
||
(lib.mkIf (cfg.settings != { } && isDarwin) { | ||
home.file."Library/Application Support/rio/config.toml".source = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe xdg.configFile does that automatically ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? it doesn't seem to be the case. Can you point me the source code where this is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the code and let the tests run and it failed. So it doesn't work indeed.
zsh-session-variables: OK
rio-example-settings: FAILED
Expected home-files/Library/Application Support/rio/config.toml to exist but it was not found.
For further reference please introspect /nix/store/ph3drnq8yckanhmkqz1jp0gmgj4l7nsg-nmt-report-rio-example-settings
8292792
to
18efc77
Compare
What's the status on this so far? @otavio |
AFAIK it is ready, I just need to rebase. |
@otavio Nice! I was going to make my own rio module but seeing as it's ready I'll just wait. |
Please give it a try |
@otavio Did some light testing and it seems to work fine :) |
needs a rebase |
Signed-off-by: Otavio Salvador <[email protected]>
Adds a programs.rio module to control Rio installation and configuration, a gpu accelerated terminal Signed-off-by: Otavio Salvador <[email protected]>
Description
Adds a
programs.rio
module to control Rio installation and configuration.Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module