rio: add module #4118
Merged
rio: add module #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46a25df
to
a48b24a
Compare
teto
reviewed
Jun 21, 2023
| }) | ||
|
|
||
| (lib.mkIf (cfg.settings != { } && isDarwin) { | ||
| home.file."Library/Application Support/rio/config.toml".source = |
There was a problem hiding this comment.
I believe xdg.configFile does that automatically ?
There was a problem hiding this comment.
Are you sure? it doesn't seem to be the case. Can you point me the source code where this is set?
There was a problem hiding this comment.
I changed the code and let the tests run and it failed. So it doesn't work indeed.
zsh-session-variables: OK
rio-example-settings: FAILED
Expected home-files/Library/Application Support/rio/config.toml to exist but it was not found.
For further reference please introspect /nix/store/ph3drnq8yckanhmkqz1jp0gmgj4l7nsg-nmt-report-rio-example-settings
teto
reviewed
Jun 21, 2023
8292792
to
18efc77
Compare
rycee
reviewed
Jul 10, 2023
rycee
reviewed
Jul 10, 2023
rycee
reviewed
Jul 10, 2023
|
What's the status on this so far? @otavio |
|
AFAIK it is ready, I just need to rebase. |
|
@otavio Nice! I was going to make my own rio module but seeing as it's ready I'll just wait. |
|
Please give it a try |
|
@otavio Did some light testing and it seems to work fine :) |
teto
reviewed
Sep 18, 2023
|
needs a rebase |
Signed-off-by: Otavio Salvador <[email protected]>
fufexan
pushed a commit
to fufexan/home-manager
that referenced
this pull request
Feb 24, 2024
Adds a programs.rio module to control Rio installation and configuration, a gpu accelerated terminal Signed-off-by: Otavio Salvador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
programs.riomodule to control Rio installation and configuration.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module