Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove pdb breakpoint and make single-op-splits robust to 1d shape #758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ibevers
Copy link

@ibevers ibevers commented Jun 6, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Removes a stray pdb breakpoint and makes the splitter functionality robust to 1D inputs for singleton splitters.

Checklist

I will add a test for this case.

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@effigies
Copy link
Contributor

effigies commented Jun 7, 2024

Thanks! This looks reasonable on first glance. Would you mind creating a test that exercises this edge case?

@djarecka
Copy link
Collaborator

Hi @ibevers, let me know if you need some help with adding the tests

@ibevers
Copy link
Author

ibevers commented Jun 11, 2024

Hi @ibevers, let me know if you need some help with adding the tests

Hi @djarecka, thank you, I will add them by the end of this week. I have a few other things that I need to take care of first

@ibevers
Copy link
Author

ibevers commented Jun 17, 2024

@djarecka, I spent a while on this, but I was unable to generate a case that triggers if op_single in self.inner_inputs. Would you kindly help me? I think I would need to spend more time than I have reading Pydra source code to know what to do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants