Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for --error and --output as sbatch_args in test_submitter #638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adi611
Copy link
Contributor

@adi611 adi611 commented Mar 29, 2023

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Added tests for valid --error and --output as sbatch_args.

Checklist

I am getting error for test_slurm_args_3 while testing (which checks for --error) - AttributeError: 'NoneType' object has no attribute 'replace'
image
Possible reason for this could be in workers.py here. In this, we are assigning error_file to None when --error flag is indeed detected. And later we are using .replace() function on error_file which is None in our case.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +43.44 🎉

Comparison is base (5ada4ca) 38.27% compared to head (7bc7013) 81.72%.

❗ Current head 7bc7013 differs from pull request most recent head 0acb8a7. Consider uploading reports for the commit 0acb8a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #638       +/-   ##
===========================================
+ Coverage   38.27%   81.72%   +43.44%     
===========================================
  Files          20       20               
  Lines        4394     4394               
  Branches     1202        0     -1202     
===========================================
+ Hits         1682     3591     +1909     
+ Misses       2417      803     -1614     
+ Partials      295        0      -295     
Flag Coverage Δ
unittests 81.72% <ø> (+43.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant