move import of etelemetry inside try block #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ingest the mindboggle parcellation labels into the NIF Ontology we run the following `from mindboggle.mio.labels import DKTprotocol as dkt`, which has no dependencies, and thus can be run by simply cloning this repository and not having to bother with installing a bunch of dependencies. Importing a dependency in the top level __init__ breaks this convenient behavior and also adds a network roundtrip for what should be a much simpler operation. This commit moves the etelemetry import inside the try/except block so that failure to import etelemetry does not prevent accessing static information in labels.py.
binarybottle
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ingest the mindboggle parcellation labels into the NIF Ontology we run the following
from mindboggle.mio.labels import DKTprotocol as dkt, which has no dependencies, and thus can be run by simply cloning this repository and not having to bother with installing a bunch of dependencies. Importing a dependency in the top level init breaks this convenient behavior and also adds a network roundtrip for what should be a much simpler operation. This commit moves the etelemetry import inside the try/except block so that failure to import etelemetry does not prevent accessing static information in labels.py.