Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble publish when parsing tags, if whitespace strutils.split() puts empty string in packages.json #1204

Closed
bloomingchad opened this issue Apr 2, 2024 · 1 comment · Fixed by #1205
Assignees

Comments

@bloomingchad
Copy link

bloomingchad commented Apr 2, 2024

when you publish using nimble, it asks for tags. if a newbie user is typing the tags,

for example: "tag1 tag2 tag3 tag4 "<<<(this last char before ")
the trailing white space at the last will be parsed as a empty string [""] into tags field of packages.json

this will result in a ci error where the package_scanner.nim will return
at line 157: logPackageError(displayName & " has empty tags")

wasted ci resources, redundant workflow approvals, wasted time and makes us look buggy.

@Araq
Copy link
Member

Araq commented Apr 2, 2024

If only the stdlib had something like splitWhitespace...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants