Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #22553; regression of offsetof(T, anFieldOfUncheckedArray) #24014

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ringabout
Copy link
Member

fixes #22553

follow up #21979 which introduced a char dummy member prepended to objs only containing an UncheckedArray

@Araq Araq merged commit 7e88091 into devel Aug 27, 2024
22 checks passed
@Araq Araq deleted the pr_sizeoffset_2 branch August 27, 2024 07:45
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 7e88091

Hint: mm: orc; opt: speed; options: -d:release
173725 lines; 8.906s; 654.5MiB peakmem

@ringabout ringabout restored the pr_sizeoffset_2 branch August 27, 2024 14:37
@ringabout ringabout deleted the pr_sizeoffset_2 branch August 27, 2024 14:38
metagn added a commit to metagn/Nim that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offsetof(T, anFieldOfUncheckedArray) returned the wrong value
2 participants