Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the tests of options #16527

Merged
merged 2 commits into from
Jan 1, 2021
Merged

refactor the tests of options #16527

merged 2 commits into from
Jan 1, 2021

Conversation

ringabout
Copy link
Member

I planed to work on timotheecour#6 (comment), however #15730 blocks me.

So I could only refactor the tests of options.
I also find a bug:

import options

# change to templates, it works
# closure anonymous functions doesn't work in VM with JS
# Error: cannot evaluate at compile time: procRan
proc main() =
  var procRan = 0
  some(123).map(proc (v: int) = procRan = v)

static: main()

@juancarlospaco
Copy link
Collaborator

Looks good 👍

@Araq Araq merged commit b5101b2 into nim-lang:devel Jan 1, 2021
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants