Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #9227 procs can now have multiple interleaved doc comments + runnableExamples and be docgen'd correctly #14441

Merged
merged 3 commits into from
May 25, 2020
Merged

fix #9227 procs can now have multiple interleaved doc comments + runnableExamples and be docgen'd correctly #14441

merged 3 commits into from
May 25, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented May 24, 2020 •
edited
Loading

@timotheecour timotheecour requested a review from Araq May 24, 2020 12:29
@Clyybber Clyybber changed the title https://github.com/nim-lang/Nim/issues/9227 proc doc comments after 1st runnableExamples aren't ignored anymore Fix #9227 May 24, 2020
@timotheecour timotheecour changed the title Fix #9227 fix #9227 procs can now have multiple interleaved doc comments + runnableExamples and be docgen'd correctly May 24, 2020
@Araq Araq merged commit f96555b into nim-lang:devel May 25, 2020
@timotheecour timotheecour deleted the pr_fix_9227_doccomments_skipped_after_runnableExamples branch May 25, 2020 13:49
This was referenced May 25, 2020
Open
Merged
Closed
@timotheecour
Copy link
Member Author

this introduced a regression that I'm fixing here: #14439

EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
@timotheecour @EchoPouet
fix nim-lang#9227 procs can now have multiple interleaved doc comment…
b68f829 
…s + runnableExamples and be docgen'd correctly (nim-lang#14441)

* fix nim-lang#9227 proc doc comments after 1st runnableExamples are not ignored anymore
@timotheecour timotheecour mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clyybber Clyybber Clyybber left review comments

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docgen] proc doc comments silently omitted after 1st runnableExamples
3 participants
@timotheecour @Clyybber @Araq