fix(notify)!: resolve test & linter issues and fix dependencies compatibility #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tibility BREAKING CHANGE: This commit introduces significant changes to the FCM and Matrix services due to breaking changes in their respective dependencies. These changes may affect existing implementations: FCM Service: - Updated to accommodate changes in the `github.com/appleboy/go-fcm` package - Modified function signatures and type definitions to match new dependency requirements - Removed `DataKey` and `RetriesKey` - Changed `New` function signature from `func(string) (*Service, error)` to `func(context.Context, ...Option) (*Service, error)` Matrix Service: - Updated to accommodate changes in the `mautrix` package - Modified `SendMessageEvent` method signature to include `context.Context` parameter Additional changes: - Added new options for FCM service: `Option`, `WithCredentialsFile`, `WithHTTPClient`, `WithProjectID` - Updated tests and fixed linter complaints throughout the codebase This commit aims to maintain compatibility with the latest versions of our dependencies while improving code quality. Users of the FCM and Matrix services will need to update their implementations to match the new function signatures and removed keys.
Removed CodeQL as I found no intuitive way of bringing it up-to-date manually. Removing it, and GitHub will re-add it to the project soon with an up-to-date config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE: This commit introduces significant changes to the FCM and Matrix services due to breaking changes in their respective dependencies. These changes may affect existing implementations:
FCM Service:
github.com/appleboy/go-fcmpackageDataKeyandRetriesKeyNewfunction signature fromfunc(string) (*Service, error)tofunc(context.Context, ...Option) (*Service, error)Matrix Service:
mautrixpackageSendMessageEventmethod signature to includecontext.ContextparameterAdditional changes:
Option,WithCredentialsFile,WithHTTPClient,WithProjectIDThis commit aims to maintain compatibility with the latest versions of our dependencies while improving code quality. Users of the FCM and Matrix services will need to update their implementations to match the new function signatures and removed keys.
Fixes #837.