Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): use blank identifier for context #569

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

nikoksr
Copy link
Owner

@nikoksr nikoksr commented Mar 22, 2023

Description

Sets an unused ctx context.Context in lark's WebhookService.Send method to a blank identifier.

Motivation and Context

Fixes the linter complaint as seen here for example. We're not removing the context parameter from the method as it keeps the method signature consistent with the rest of the codebase.

How Has This Been Tested?

Ran linter locally, no more complaints. Test suite passes as well.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f708cf6) 75.07% compared to head (60771fe) 75.07%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   75.07%   75.07%           
=======================================
  Files          41       41           
  Lines        1376     1376           
=======================================
  Hits         1033     1033           
  Misses        251      251           
  Partials       92       92           
Impacted Files Coverage Δ
service/lark/webhook.go 39.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikoksr nikoksr merged commit 6ad4b13 into main Mar 22, 2023
@nikoksr nikoksr deleted the fix/linter-complain branch March 22, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants