-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): Add Google Chat Service #501
Conversation
Fixes issue nikoksr#459
Codecov ReportBase: 75.39% // Head: 75.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 75.39% 75.18% -0.21%
==========================================
Files 38 41 +3
Lines 1276 1366 +90
==========================================
+ Hits 962 1027 +65
- Misses 234 249 +15
- Partials 80 90 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EthanEFung what an amazing PR! We appreciate it so much. Really, really high quality delivered from you here.
I just added some minor formatting/style changes, a missing comment or two, and one (I suppose) minor thing that needs our exchange. Other than that, there's basically nothing to do! Can't wait to get this merged into Notify.
doc: fix documentation for README and doc.go
…to ethanefung/issue459
b9341b4
to
434607a
Compare
434607a
to
7fc2eb6
Compare
Hey @nikoksr I'm having some trouble trying to resolve my dependencies with the main branch. I've tried resolving the conflicts by editing the go.mod file directly and running |
@EthanEFung sure thing! Should be resolved now. Could you please verify that everything's still working as intented? Tests and linter are happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, all looking good! Waiting for your confirmation that everything's still working as intended and we're ready to merge.
@nikoksr Works well on my end |
@EthanEFung alright, ready to merge. Thank you so much once again for your contribution, we really appreciate it. |
…ush-notification-service * 'main' of https://github.com/nikoksr/notify: (65 commits) fix(deps): update module github.com/aws/aws-sdk-go-v2/config to v1.18.13 (nikoksr#529) fix(deps): update module github.com/plivo/plivo-go/v7 to v7.19.0 (nikoksr#528) fix(deps): update module google.golang.org/api to v0.110.0 (nikoksr#527) fix(deps): update module github.com/bwmarrin/discordgo to v0.27.0 (nikoksr#509) fix(deps): update module github.com/aws/aws-sdk-go-v2/service/sns to v1.20.2 (nikoksr#526) fix(deps): update module github.com/mailgun/mailgun-go/v4 to v4.8.2 (nikoksr#525) fix(deps): update module github.com/aws/aws-sdk-go-v2/service/sns to v1.20.1 (nikoksr#524) fix(deps): update module github.com/aws/aws-sdk-go-v2/service/ses to v1.15.1 (nikoksr#523) fix(deps): update module github.com/aws/aws-sdk-go-v2/config to v1.18.12 (nikoksr#522) fix(deps): update module github.com/aws/aws-sdk-go-v2 to v1.17.4 (nikoksr#521) fix(deps): update module github.com/aws/aws-sdk-go-v2/service/sns to v1.20.0 (nikoksr#520) fix(deps): update module github.com/aws/aws-sdk-go-v2/config to v1.18.11 (nikoksr#519) fix(deps): update module google.golang.org/api to v0.109.0 (nikoksr#518) fix(deps): update module github.com/plivo/plivo-go/v7 to v7.18.0 (nikoksr#517) fix(deps): update module github.com/aws/aws-sdk-go-v2/config to v1.18.10 (nikoksr#515) fix(deps): update module github.com/aws/aws-sdk-go-v2/service/sns to v1.19.1 (nikoksr#514) fix(deps): update module github.com/aws/aws-sdk-go-v2/config to v1.18.9 (nikoksr#512) fix(deps): update module google.golang.org/api to v0.108.0 (nikoksr#511) feat(service): Add Google Chat Service (nikoksr#501) fix(deps): update module github.com/plivo/plivo-go/v7 to v7.17.1 (nikoksr#510) ...
Fixes issue #459
Description
Implements Google Chat Service integration.
Motivation and Context
This PR solves Issue #459
How Has This Been Tested?
Decent unit test coverage
Manual Testing
Types of changes
Checklist: