Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): Add Pushover service #467

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

joshm91
Copy link
Contributor

@joshm91 joshm91 commented Nov 17, 2022

Description

Implement Pushover service to fix #456

Motivation and Context

How Has This Been Tested?

  • Unit tests

image

* End to end test

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@svaloumas svaloumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @joshm91 !

Thank you very much for your efforts and contribution! That's a beautifully made PR 🚀
Could you please add a doc.go file, like this for example, just for completeness? I think we're good to go once you take care of it.

@joshm91
Copy link
Contributor Author

joshm91 commented Nov 18, 2022

@svaloumas doc.go has been added! 🎉

@codecov-commenter
Copy link

Codecov Report

Base: 72.48% // Head: 73.04% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (0cbd639) compared to base (db14718).
Patch coverage: 84.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   72.48%   73.04%   +0.55%     
==========================================
  Files          32       34       +2     
  Lines         985     1035      +50     
==========================================
+ Hits          714      756      +42     
- Misses        203      207       +4     
- Partials       68       72       +4     
Impacted Files Coverage Δ
service/pushover/mock_pushover_client.go 73.91% <73.91%> (ø)
service/pushover/pushover.go 92.59% <92.59%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@svaloumas svaloumas merged commit f1cc041 into nikoksr:main Nov 18, 2022
@svaloumas
Copy link
Collaborator

We appreciate your time and efforts @joshm91 ! We'd certainly love to see more contributions from you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(service): Add Pushover service
3 participants