ci(lint): add setup-go action to lint job #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Twitter client library we use is not maintained anymore. We should consider switching to a maintained library. Marking this as potentially instable. See here for more information: https://github.com/dghubble/go-twitter#go-twitter----
nikoksr
added
affects/docs
Codecov ReportBase: 72.48% // Head: 72.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 72.48% 72.48%
=======================================
Files 32 32
Lines 985 985
=======================================
Hits 714 714
Misses 203 203
Partials 68 68 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1 task
svaloumas
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
setup-goaction before the linter job runs. Updated the README slightly; added a warning about the deprecated Twitter service.Motivation and Context
Added
setup-goaction to prevent future linter problems due to missing or untidy go dependencies. In private tests this showed to stabilize the workflow and prevent false positives.There should be a noticeable warning about the deprecated Twitter client library in the Readme to make people prematurely aware about potential problems with the service.
Types of changes
Checklist: