Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): Add Viber #415

Merged
merged 17 commits into from
Oct 25, 2022
Merged

feat(service): Add Viber #415

merged 17 commits into from
Oct 25, 2022

Conversation

irfansofyana
Copy link
Contributor

@irfansofyana irfansofyana commented Oct 8, 2022

Description

Implement Viber service to solve #114

Motivation and Context

How Has This Been Tested?

  • Unit Test
    image

  • End-to-end testing
    image

Screenshots / Output (if appropriate):

  • Screenshot End to end testing
    The script that is used can be seen in the README with some modifications to change dummy values.
    image

  • Unit Test
    image

  • All Test Results
    There is a failure in syslog service but it's not related with this PR, maybe we can solve it in different PR?
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@irfansofyana irfansofyana marked this pull request as ready for review October 8, 2022 15:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Base: 72.18% // Head: 72.48% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (697cea4) compared to base (7624ce3).
Patch coverage: 77.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   72.18%   72.48%   +0.30%     
==========================================
  Files          30       32       +2     
  Lines         924      985      +61     
==========================================
+ Hits          667      714      +47     
- Misses        197      203       +6     
- Partials       60       68       +8     
Impacted Files Coverage Δ
service/matrix/mock_matrix_client.go 70.00% <ø> (ø)
service/viber/mock_viber_client.go 68.42% <68.42%> (ø)
service/viber/viber.go 91.30% <91.30%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@svaloumas svaloumas self-requested a review October 17, 2022 19:53
service/viber/viber_test.go Show resolved Hide resolved
service/viber/viber.go Show resolved Hide resolved
service/viber/viber.go Outdated Show resolved Hide resolved
service/viber/README Outdated Show resolved Hide resolved
@nikoksr nikoksr changed the title feat: implement viber service feat(service): Add Viber Oct 20, 2022
@irfansofyana
Copy link
Contributor Author

hey @svaloumas thanks for your time on reviewing this. I've addressed your comments, please help to re-review it again, thank you!

also @nikoksr would appreciate if you have any comment on this PR. Thank you!

@nikoksr
Copy link
Owner

nikoksr commented Oct 24, 2022

@irfansofyana I appreciate your hustle. I firmly believe @svaloumas reviews are of a consistent high quality. There won't be additional value my review could provide.

@irfansofyana
Copy link
Contributor Author

@nikoksr gotcha, thank you!

@svaloumas
Copy link
Collaborator

@irfansofyana Apologies for getting back late to this! Let's just remove this sneaky line here that causes the linter failure and we're ready to go! 👍

@irfansofyana
Copy link
Contributor Author

@svaloumas upss sorry for that, it should be fixed now. Thanks!

@svaloumas svaloumas merged commit 8aa5c9d into nikoksr:main Oct 25, 2022
@irfansofyana irfansofyana deleted the feat/viper branch November 4, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants