test(services): expand services test coverage #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most services are testing by mocking them. To unify the way how and where these mocks are being generated, I added the mock command. The command executes go generate against all subdirectories internally. For this to work every service needs a go:generate comment that defines the mockery command to be executed. For examples, check 'service/amazonses/amazon_ses.go#14'. All newly added tests should make use of this pattern.
Codecov ReportBase: 55.91% // Head: 61.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 55.91% 61.64% +5.73%
==========================================
Files 21 29 +8
Lines 719 975 +256
==========================================
+ Hits 402 601 +199
- Misses 286 322 +36
- Partials 31 52 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
svaloumas
reviewed
Sep 12, 2022
Co-authored-by: Stefanos Valoumas <[email protected]>
Co-authored-by: Stefanos Valoumas <[email protected]>
svaloumas
approved these changes
Sep 12, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Took the time and added some more mocks and tests. Added mocks and tests for 4 services (
msteams,amazonses,discord,slack).Also added a new make command, namely
mock. All mock does is wrapgo generate ./.... Services from now on should include a line similar to this. This unifys the way that mocks are being generated and allows for quick re-generation of said mocks. Over time, additionally to adding more tests in general, more of the "older" tests should adapt this behavior, too.Motivation and Context
Since
Notifyshould ideally have as close to 100% test coverage as possible, this is a step that brings us closer to that goal.How Has This Been Tested?
Ran the tests locally multiple times.
Types of changes
Checklist:
cc @svaloumas