feat(notify): add NewWithServices() constructor function #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AddNewWithServices() accepts a variadic list of services and returns a new, by New() created, Notify instance with the list of services set as its notifiers. If no services are given it's the functionally identical to just calling New(). Calling NewWithServices() with a list of services is functionally equal to calling New() and then UseServices().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NewWithServices()accepts a variadic list of services and returns a new, byNew()created,Notifyinstance with the list of services set as its notifiers.If no services are given it's the functionally identical to just calling
New()directly. CallingNewWithServices()with a list of services is functionally equal to callingNew()and thenUseServices().Motivation and Context
A small convenience construcor that potentially saves one or more additional function calls.
How Has This Been Tested?
Added tests.
Types of changes
Checklist: