Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): Added Pushbullet service (tested) #20

Merged
merged 18 commits into from
Feb 2, 2021

Conversation

KrishanBhalla
Copy link
Contributor

@KrishanBhalla KrishanBhalla commented Feb 1, 2021

Info

Adding a Pushbullet service for notification across devices.

Proposed Changes

  1. Added new Pushbullet service (https://www.pushbullet.com/)
  2. Added usage.md
  3. Updated README.md to include pushbullet.
  4. Added new Pushbullet SMS service.
  5. Updated pushbullet/usage.md for pushbullet sms

Note

Tested locally with an android device and google chrome. SMS was tested on Android.

Copy link
Owner

@nikoksr nikoksr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - just check on that one section, please.

README.md Outdated Show resolved Hide resolved
service/pushbullet/usage.md Outdated Show resolved Hide resolved
service/pushbullet/pushbullet.go Show resolved Hide resolved
service/pushbullet/pushbullet.go Outdated Show resolved Hide resolved
service/pushbullet/sms.go Outdated Show resolved Hide resolved
service/pushbullet/sms.go Outdated Show resolved Hide resolved
Copy link
Owner

@nikoksr nikoksr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're gonna return an error in Send until we find a better solution.

service/pushbullet/pushbullet.go Outdated Show resolved Hide resolved
service/pushbullet/pushbullet.go Outdated Show resolved Hide resolved
service/pushbullet/pushbullet.go Outdated Show resolved Hide resolved
service/pushbullet/sms.go Outdated Show resolved Hide resolved
service/pushbullet/pushbullet.go Outdated Show resolved Hide resolved
service/pushbullet/usage.md Outdated Show resolved Hide resolved
service/pushbullet/usage.md Outdated Show resolved Hide resolved
@KrishanBhalla
Copy link
Contributor Author

#21 has been created in relation to changes

Copy link
Owner

@nikoksr nikoksr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, really appreciate your contributions!

@nikoksr nikoksr merged commit d6d3ed1 into nikoksr:main Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants