Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Docs v5 #318

Merged
merged 9 commits into from
Jun 9, 2024
Merged

Feature Docs v5 #318

merged 9 commits into from
Jun 9, 2024

Conversation

nikcio
Copy link
Owner

@nikcio nikcio commented Jun 7, 2024

No description provided.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Comment on lines +151 to +154
List<IContentTypeComposition> allContentTypes = GetContentTypes();
List<IContentTypeComposition> interfacedContentTypes = [];

var interfaceTypeNames = new HashSet<string>(StringComparer.Ordinal);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Bumpy Road Ahead
GenerateTypes has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

Suppress

return interfaceTypeDefinition;
}

private ObjectTypeDefinition CreateObjectTypeDefinition(IContentTypeComposition contentType)
private ObjectTypeDefinition CreateObjectTypeDefinition(IContentTypeComposition contentType, HashSet<string> interfaceTypeNames)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Bumpy Road Ahead
CreateObjectTypeDefinition has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

Suppress

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

@nikcio nikcio marked this pull request as ready for review June 9, 2024 12:56
@nikcio nikcio merged commit ce02300 into contrib Jun 9, 2024
6 checks passed
@nikcio nikcio deleted the feature/docs-v5 branch June 9, 2024 12:59
Copy link

sonarcloud bot commented Jun 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant