Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4055 #4061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aditya123473892
Copy link

@aditya123473892 aditya123473892 commented Feb 26, 2024

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@aditya123473892
Copy link
Author

@garg3133 sir can u help me in finding my mistakes in my pr i am very much confused
or any specific way i should try to work on it

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to test the changes you've made thoroughly by using it in any of the Nightwatch example tests before asking for review. But you are free to ask questions if you don't understand something.

@garg3133
Copy link
Member

@aditya123473892 You can try to use VSCode Debugger to go through the codebase. Try adding a breakpoint in the method-mappings file and try to see what you're getting there and how can you decide whether an element is present or not.

In general, if an instance of WebElement is available, then that would mean that the element is present. If there is no element, there would be no WebElement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants