-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to hide dump_svg
/dump_into_svg
?
#13
Comments
Hi, sorry for the delay I've been away from computers for a couple of weeks.
Unless you have evidence that build times or release binary sizes are noticeably affected I would prefer to keep it without feature gate for simplicity's sake. |
No problem! I'm targeting WebAssembly, so the concern is mostly about binary size and generally avoiding any extra dependencies. I'll check whether it's included into the final binary – maybe it's already being eliminated during build/linking like you mentioned. |
A lot of crates depending on this crate probably won't use
dump_svg
ordump_into_svg
, so it would be great if we could remove this dependency by default and still have a way to opt-in (e.g. with asvg
feature or similar).I'd be happy to PR this if that sounds good.
The text was updated successfully, but these errors were encountered: