Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LaunchNIVeriStand and example #39

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Fix LaunchNIVeriStand and example #39

merged 3 commits into from
Dec 7, 2021

Conversation

CiprianAnton
Copy link
Collaborator

@CiprianAnton CiprianAnton commented Dec 3, 2021

[ ] This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

LaunchNIVeriStand does not work with VeriStand >= 2019. Wrong path is being used.

This PR will fix that and also make the example run with success.

Fixes issue #36 where NI VeriStand does not launch when calling the LaunchNIVeriStand function in the legacy API.

Why should this Pull Request be merged?

Fixes a bug

What testing has been done?

The exampled passed with success using VeriStand 2021

Improve example by adding a function that waits for server to start

Make the example run with success
src/niveristand/legacy/NIVeriStand.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants