-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable mention intermittent failed cases #2403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/ni/nimble into users/aagash/intermittent-mention-test
aagash-ni
requested review from
rajsite,
jattasNI and
vivinkrishna-ni
as code owners
September 19, 2024 14:03
jattasNI
approved these changes
Sep 19, 2024
rajsite
reviewed
Sep 19, 2024
packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should poke at isMentionListboxOpened a bit more
rajsite
reviewed
Oct 9, 2024
packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts
Show resolved
Hide resolved
rajsite
approved these changes
Oct 14, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Issue: #2219
We are re-enabling tests that were previously disabled due to intermittent failures and disabling only in the Firefox environment, as the issue occurred only once during four days of testing. Additionally, there were other cases that are validating the same mention workflow, which has been successfully running in Firefox.
After conducting tests in a loop environment on GitHub agents, the tests did not fail with the same error.
Please refer to the bug discussion for all the pipeline checks: Bug 2787273 - Intermittent failures in the Rich Text Editor for Mention support.
Following this, we will monitor for any related failures and have created a TD to track the skipped Firefox browser tests.
👩💻 Implementation
Re-enabled the disabled test case.
Update:
should show mention popup for multiple mention configuration elements
:@
mention node, remove the@
and add!
to verify other mention type list options and popup visibility.Serialize rich text editor content to its respective markdown Mention node
:clickMentionListboxOption
to focus on the editor before committing the mention from the list options.isMentionListboxOpened
method to read from thehidden
property and also wait before reading to resolve the intermittent failures on Firefox when running in loop.See the discussion below for more details, #2403 (comment)
🧪 Testing
NA
✅ Checklist