Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable mention intermittent failed cases #2403

Merged
merged 11 commits into from
Oct 14, 2024

Conversation

aagash-ni
Copy link
Contributor

@aagash-ni aagash-ni commented Sep 19, 2024

Pull Request

🤨 Rationale

Issue: #2219

We are re-enabling tests that were previously disabled due to intermittent failures and disabling only in the Firefox environment, as the issue occurred only once during four days of testing. Additionally, there were other cases that are validating the same mention workflow, which has been successfully running in Firefox.

After conducting tests in a loop environment on GitHub agents, the tests did not fail with the same error.

Please refer to the bug discussion for all the pipeline checks: Bug 2787273 - Intermittent failures in the Rich Text Editor for Mention support.

Following this, we will monitor for any related failures and have created a TD to track the skipped Firefox browser tests.

👩‍💻 Implementation

Re-enabled the disabled test case.

Update:

  1. For test should show mention popup for multiple mention configuration elements:
    1. Instead of committing the @ mention node, remove the @ and add ! to verify other mention type list options and popup visibility.
    2. The test can now verify the list options for multiple mentions by opening the popup.
  2. For test Serialize rich text editor content to its respective markdown Mention node:
    1. Update the clickMentionListboxOption to focus on the editor before committing the mention from the list options.
  3. Update other methods that modify the content of the editor to also receive focus to the editor to ensure any other intermittencies.
  4. Update the isMentionListboxOpened method to read from the hidden property and also wait before reading to resolve the intermittent failures on Firefox when running in loop.

See the discussion below for more details, #2403 (comment)

🧪 Testing

NA

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@aagash-ni aagash-ni marked this pull request as ready for review September 19, 2024 14:03
@rajsite rajsite marked this pull request as draft September 30, 2024 22:01
@vivinkrishna-ni vivinkrishna-ni marked this pull request as ready for review October 4, 2024 07:00
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should poke at isMentionListboxOpened a bit more

@rajsite rajsite merged commit 69ed3ce into main Oct 14, 2024
14 checks passed
@rajsite rajsite deleted the users/aagash/intermittent-mention-test branch October 14, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants